[PATCH] D73832: Ignore/Drop droppable uses for code-sinking in InstCombine

[Tyker via Phabricator via llvm-commits]

Tyker marked an inline comment as done.
Tyker added inline comments.


================
Comment at: llvm/lib/IR/AsmWriter.cpp:2557
 
+    /// Bundles containing dropped values should be ignored.
+    if (any_of(BU.Inputs, [](const Use &U) { return !U.get(); }))
----------------
lebedev.ri wrote:
> Would it be better to ensure that we can't end up in such
> seemingly-degenerate state in the first place,
> by cleaning up bundles?
i agree than not having that state would be better but i don't think it is possible without rebuilding instruction after we dropped uses in them.

an other solution could be to mark dropped uses with an undef value instead of a nullptr.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73832/new/

https://reviews.llvm.org/D73832