[PATCH] D73832: Ignore/Drop droppable uses for code-sinking in InstCombine

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 20 03:29:41 PST 2020


lebedev.ri added inline comments.


================
Comment at: llvm/lib/IR/AsmWriter.cpp:2557
 
+    /// Bundles containing dropped values should be ignored.
+    if (any_of(BU.Inputs, [](const Use &U) { return !U.get(); }))
----------------
Would it be better to ensure that we can't end up in such
seemingly-degenerate state in the first place,
by cleaning up bundles?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73832/new/

https://reviews.llvm.org/D73832





More information about the llvm-commits mailing list