[PATCH] D74856: [AArch64][SVE] Add backend support for splats of immediates

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Maybe worth changing the test to use "-mattr=+sve,+fullfp16", so the f16 tests work?



================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:13
 
+def SVE8BitLslImm : ComplexPattern<i32, 2, "SelectSVE8BitLslImm", [imm]>;
+
----------------
cameron.mcinally wrote:
> efriedma wrote:
> > Is there some reason you can't use the existing cpy_imm8_opt_lsl_i8?
> I'm not sure I understand this one. What should I replace with cpy_imm8_opt_lsl_i8?
> 
> SVE8BitLslImm is looking for two i8 immediates (i8 value and i8 shift amount).
> 
> cpy_imm8_opt_lsl_i8 is just checking for one i8 immediate, IINM.
"class imm8_opt_lsl" has some code which looks like it supposed to be used for matching.  Granted, it's using ImmLeaf, so maybe it's just broken.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74856/new/

https://reviews.llvm.org/D74856