[PATCH] D74822: [AArch64][ASMParser] Refuse equal source/destination for LDRAA/LDRAB

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:4123
+      return Error(Loc[0],
+          "unpredictable LDRA instruction, writeback base is also a source");
+    break;
----------------
Pierre-vh wrote:
> ostannard wrote:
> > s/source/destination/ ?
> What do you mean? Should I change the error message? What do you suggest?
The change you've made is what I meant: the last word of the message is referring to Xt, which is a destination register, not as source.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74822/new/

https://reviews.llvm.org/D74822