[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin requested changes to this revision.
ikudrin added a comment.
This revision now requires changes to proceed.

In D73086#1867037 <https://reviews.llvm.org/D73086#1867037>, @SouraVX wrote:

> In D73086#1866759 <https://reviews.llvm.org/D73086#1866759>, @ikudrin wrote:
>
> > Please, make the `DebugLineOffset` field optional, as that is required by the DWARF standard.
>
>
> Indeed it's optional, but I think it should be absolutely present, Please consider @probinson comment in D72828 <https://reviews.llvm.org/D72828>.


I am sure that @probinson meant a producer, not a dumper. Note that the current implementation is even unable to parse an example from the standard, see fig. D.72 on p. 363, DWARFv5.



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp:120
+      // 3. Macro string
+      strOffset = data.getRelocatedValue(4 /*Offset Size*/, Offset);
+      E.MacroStr = Context.getStringExtractor().getCStr(&strOffset);
----------------
Please, add a "// TODO: Add support for DWARF64" comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086