[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

Tue Feb 18 18:30:41 PST 2020

dblaikie added a comment.

In D73086#1881724 <https://reviews.llvm.org/D73086#1881724>, @SouraVX wrote:

> BTW, If you're okay with generation part D72828 <https://reviews.llvm.org/D72828>, Can you please accept that??

I do not want to approve that patch until this patch has been committed - since that patch should use the functionality provided by this patch for testing.

> I'm asking this because, this dumping patch is based on top of that.

It should be (& I think it is?) the other way around - the LLVM functionality patch should depend on this dumping patch, because the functionality patch should use the dumping patch for testing.

> So while working on this, I do not have to think about /changes/rebase and all/ about that. As I recall, Adrian & Paul has already shared their acceptance previously.

I'd not worry about keeping the other patch up to date, etc, while this review is happening - wait until this patch is done and committed, then update the other patch to use the final functionality that's committed here.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086