[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

[Pengxuan Zheng via Phabricator via llvm-commits]

pzheng added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.cpp:102
+
+    Streamer.EmitIntValue(ELFBuildAttrs::Format_Version, 1);
+  }
----------------
should be "Streamer.emitIntValue"

same for all other "Streamer.emitXXX" references


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVELFStreamer.h:106
 
   virtual void emitDirectiveOptionPush();
   virtual void emitDirectiveOptionPop();
----------------
void emitDirectiveOptionPush() override;

same for all the emitDirectiveOption functions below


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:64
+
+  void EmitStartOfAsmFile(Module &M) override;
+  void EmitEndOfAsmFile(Module &M) override;
----------------
should be emitStartOfAsmFile ?


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:65
+  void EmitStartOfAsmFile(Module &M) override;
+  void EmitEndOfAsmFile(Module &M) override;
+
----------------
same here, emitEndOfAsmFile


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:164
 
+void RISCVAsmPrinter::EmitStartOfAsmFile(Module &M) {
+  const Triple &TT = TM.getTargetTriple();
----------------
emitStartOfAsmFile ?


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:171
+
+void RISCVAsmPrinter::EmitEndOfAsmFile(Module &M) {
+  const Triple &TT = TM.getTargetTriple();
----------------
emitEndOfAsmFile ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023