[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 02:32:38 PST 2020


jhenderson added inline comments.


================
Comment at: llvm/lib/Support/ELFBuildAttrs.cpp:1
+//===-- ELFBuildAttrs.cpp - ELF Build Attributes ----------------*- C++ -*-===//
+//
----------------
You don't need the language specifier for .cpp files. It is needed by some IDEs to detect the language of headers, but can be derived from the file extension in source file cases. See https://llvm.org/docs/CodingStandards.html#file-headers for details.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023





More information about the llvm-commits mailing list