[PATCH] D74471: [AArch64][SVE] Add predicate reinterpret intrinsics

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 15:11:38 PST 2020


sdesmalen requested changes to this revision.
sdesmalen added a comment.
This revision now requires changes to proceed.

In D74471#1881394 <https://reviews.llvm.org/D74471#1881394>, @efriedma wrote:

> Do you mean the way the C intrinsics are lowered gives some protection?


Correct, the intrinsics are intended to be created by the Clang ACLE implementation, which will reinterpret-cast the predicate results to svbool_t. Without optimisations that introduce a pattern like you describe, nothing breaks in practice. Of course when we will start adding such optimisations, that changes things.

I'm happy with the decision to focus on correctness first though, it probably shouldn't be too hard to fold away the explicit zeroing.

@c-rhodes can you update this patch to explicitly zero the other lanes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74471/new/

https://reviews.llvm.org/D74471





More information about the llvm-commits mailing list