[PATCH] D74471: [AArch64][SVE] Add predicate reinterpret intrinsics

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 13:49:26 PST 2020


efriedma added a comment.

I'd prefer correctness first, optimizations later.  If we miss the optimization, it's a giant red flag to anyone reading the assembly.  If we miss correctness, some very unlucky person might waste days trying to track down a miscompile.

> At the moment though, this is not really a problem

I'm not sure what you mean by this; you can trivially break the defined semantics by just writing convert.to.svbool(convert.from.svbool(ptrue)).  Do you mean the way the C intrinsics are lowered gives some protection?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74471/new/

https://reviews.llvm.org/D74471





More information about the llvm-commits mailing list