[PATCH] D74425: [DebugInfo]: Added support for DWARFv5 Info section header parsing in llvm-dwp utility.

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/tools/llvm-dwp/X86/wrong-unit-type-info-v5.s:4
+
+# CHECK: error: {{.*}}: unit type DW_UT_split_compile type not found in debug_info header. Unexpected unit type '0x12'found!
+	.section	.debug_info.dwo,"e", at progbits
----------------
SouraVX wrote:
> dblaikie wrote:
> > missing space between the unexpected unit type and the word 'found'.
> > 
> > (do other error messages use quotation marks around integer constants like this? I'd guess not & would recommend following that convention here - but could you check/verify that?)
> Their is as such precedent, although removed Single Quotes. One thing I noticed considering other error handling in DWP, We don't emit forms, simple fire an error
> 
> Line:170
> eturn make_error<DWPError>("top level DIE is not a compile unit");
Yeah, I think that's an example of an error message that could be improved but hasn't been as yet.

Please remove the exclamation mark from the error message.

(hmm, it looks like the test has been updated but this test would currently fail because it looks like the implementation still has the same output format/bugs)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74425/new/

https://reviews.llvm.org/D74425