[PATCH] D74425: [DebugInfo]: Added support for DWARFv5 Info section header parsing in llvm-dwp utility.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked 2 inline comments as done.
SouraVX added inline comments.


================
Comment at: llvm/test/tools/llvm-dwp/X86/wrong-unit-type-info-v5.s:4
+
+# CHECK: error: {{.*}}: unit type DW_UT_split_compile type not found in debug_info header. Unexpected unit type '0x12'found!
+	.section	.debug_info.dwo,"e", at progbits
----------------
dblaikie wrote:
> missing space between the unexpected unit type and the word 'found'.
> 
> (do other error messages use quotation marks around integer constants like this? I'd guess not & would recommend following that convention here - but could you check/verify that?)
Their is as such precedent, although removed Single Quotes. One thing I noticed considering other error handling in DWP, We don't emit forms, simple fire an error

Line:170
eturn make_error<DWPError>("top level DIE is not a compile unit");


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74425/new/

https://reviews.llvm.org/D74425