[PATCH] D74211: [mlir] use unpacked memref descriptors at function boundaries

Diego Caballero via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 09:30:48 PST 2020


dcaballe added a comment.

> So I will be surprised if you actually had a test exercising the default calling convention with llvm.noalias that used to pass and that was broken by this change.

We actually has been testing this since before memrefs were lowered to a pointer to struct. It became useless but it worked since the `noalias` attribute was attached to the pointer to struct. However, I think I can take care of this on our side. No problem then.
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74211/new/

https://reviews.llvm.org/D74211





More information about the llvm-commits mailing list