[PATCH] D74211: [mlir] use unpacked memref descriptors at function boundaries

Mon Feb 17 20:00:02 PST 2020

mehdi_amini added a comment.

In D74211#1878702 <https://reviews.llvm.org/D74211#1878702>, @ftynse wrote:

> In D74211#1876818 <https://reviews.llvm.org/D74211#1876818>, @dcaballe wrote:
>
> > Thanks for addressing this so quickly and for the feedback! I'm giving it a try. Re reverting patches, this is a very common practice. Sometimes patches are reverted without giving an opportunity to provide a fix. It shouldn't be a problem. LLVM has a no regression policy and testing goes beyond in-tree tests since many vendors have private forks. In any case, I just provided some options so that you could decide. Thanks again for addressing this so quickly!
>
>
> I know it's common. In this specific situation, you will get in a weird situation where reverting this patch could fix your project, but break other projects, so somebody would revert the revert :)

I am not sure I agree with this: if other project already depended on a *feature* they don't get to revert a revert that was fixing a *bug* introduced with this new feature. They have to deal with this out-of-tree. 
Of course the delay matters, in this case it was just a few days later: the revert is a no-brainer for me (unless the author can provide a quick fix, as I mentioned before, and which is what happened in this case).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74211/new/

https://reviews.llvm.org/D74211