[PATCH] D74477: [llvm-ar] Simplify Windows comparePaths NFCI

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 10:24:27 PST 2020


rupprecht resigned from this revision.
rupprecht added a comment.
Herald added a subscriber: rupprecht.

In D74477#1873998 <https://reviews.llvm.org/D74477#1873998>, @andrewng wrote:

> In my modified version of widenPath...


I second grimar's request for an associated test that covers this behavior, but are you saying that the issue is your modified version of `sys::path::widenPath` breaks some llvm-ar tests, and switching to `sys::windows::UTF8ToUTF16` will keep them passing? (If so, submitting w/o an additional test sounds fine to me)

Anyway -- I trust all the other reviewers to do a better review, as I barely ever touch windows.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74477/new/

https://reviews.llvm.org/D74477





More information about the llvm-commits mailing list