[PATCH] D74477: [llvm-ar] Simplify Windows comparePaths NFCI

Andrew Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 13 03:16:31 PST 2020


andrewng added a comment.

Just to add a bit more context for this change, I have a patch in progress to fix Windows UNC path handling in widenPath and that's how I stumbled upon this usage in llvm-ar. In my modified version of widenPath, I use the length of the input as UTF-16 to decide on whether the path needs to be "expanded", which should reduce the scope for problems in this llvm-ar use case. However, it really isn't needed here and hence this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74477/new/

https://reviews.llvm.org/D74477





More information about the llvm-commits mailing list