[PATCH] D74376: [gn build] Make build fully deterministic

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 12 18:20:06 PST 2020


thakis marked an inline comment as done.
thakis added a comment.

Thanks for taking a look!



================
Comment at: llvm/utils/gn/build/BUILD.gn:21
+  # for more information.
+  use_deterministic_relative_paths_in_debug_info = false
+
----------------
rnk wrote:
> Can this be shortened to `use_relative_paths_in_debug_info`? It seems descriptive enough. Are there non-deterministic relative paths?
Done. I pulled the non-sysroot bits into D74519 which has fewer fixmes and is ready to land today. I'll rebase this on top of D74519 once D74519 is in.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74376/new/

https://reviews.llvm.org/D74376





More information about the llvm-commits mailing list