[PATCH] D74376: [gn build] Make build fully deterministic

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/utils/gn/build/BUILD.gn:21
+  # for more information.
+  use_deterministic_relative_paths_in_debug_info = false
+
----------------
Can this be shortened to `use_relative_paths_in_debug_info`? It seems descriptive enough. Are there non-deterministic relative paths?


================
Comment at: llvm/utils/gn/docs/deterministic.md:25
+
+   FIXME: Add scripts to make this less of a drag to set up.
+
----------------
I was going to ask about this, but I think I agree it should be future work after a second individual has replicated your results manually. :)


================
Comment at: llvm/utils/gn/docs/deterministic.md:71
+          >mklink /j llvm\utils\gn\sysroot\win\msvc\include ^
+                     %P%\VC\Tools\MSVC\14.23.28105\include
+          >mklink /j llvm\utils\gn\sysroot\win\msvc\lib ^
----------------
One thing to note is that if this points at the main MSVC installation, the link may become stale. The Visual Studio updater deletes old MSVC versions and adds new ones in a newly versioned directory. We may eventually want a script that detects the stale junctions and repoints them to the current installation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74376/new/

https://reviews.llvm.org/D74376