[PATCH] D73861: Added DIBasicType scale/picture_string/digits/sign attribute support.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Please do a separate patch that moves only the existing basic-type flags without introducing any new ones.  Once you have that in place, adding new flags to the field should be fairly simple to review.  But as Adrian suggests, guaranteeing proper compatibility with older bitcode is very important and it is best to implement that as a predecessor patch.

Also could you please explain what motivates this change?  I think the decimal attributes have come up previously, but it was a while ago and I am forgetting the details.



================
Comment at: llvm/include/llvm-c/DebugInfo.h:685
+                                             LLVMDWARFTypeEncoding Encoding,
+                                             LLVMDIBTFlags Flags);
 
----------------
I believe the backward-compatibility requirements for the C API are very strict, and this does not preserve backward compatibility.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73861/new/

https://reviews.llvm.org/D73861