[PATCH] D73861: Added DIBasicType scale/picture_string/digits/sign attribute support.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Could you please

- as much as reasonable split this into smaller patches
- add bitcode upgrade tests where you are moving flags around? (Check for for existing .bc tests as an example for how to write upgrade tests)



================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.h:137
+#define HANDLE_DW_DS(ID, NAME) DW_DS_##NAME = ID,
+#include "llvm/BinaryFormat/Dwarf.def"
 };
----------------
Could you please split this change out into a separate NFC commit?


================
Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:63
 HANDLE_DI_FLAG((1 << 26), NonTrivial)
-HANDLE_DI_FLAG((1 << 27), BigEndian)
-HANDLE_DI_FLAG((1 << 28), LittleEndian)
-HANDLE_DI_FLAG((1 << 29), AllCallsDescribed)
+HANDLE_DI_FLAG((1 << 27), AllCallsDescribed)
 
----------------
This patch is introducing a bitcode incompatibility, but I don't see code in MetadataLoader to upgrade the old format.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73861/new/

https://reviews.llvm.org/D73861