[PATCH] D73680: [AArch64] -fpatchable-function-entry=N, 0: place patch label after BTI

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 09:39:37 PST 2020


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/patchable-function-entry-bti.ll:15
+;; For M=0, place the label .Lpatch0 after the initial BTI.
 define void @f1() "patchable-function-entry"="1" "branch-target-enforcement" {
 ; CHECK-LABEL: f1:
----------------
nickdesaulniers wrote:
> Would it be helpful have a test for `patchable-function-entry > 1` and `branch-target-enforcement`?
I feel that may be redundant. Different numbers of NOPs are tested in patchable-function-entry.ll . For interaction with BTI, this one is sufficient.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73680/new/

https://reviews.llvm.org/D73680





More information about the llvm-commits mailing list