[PATCH] D73680: [AArch64] -fpatchable-function-entry=N, 0: place patch label after BTI

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

Indeed, it looks like just from the emitted assembly GCC and LLVM will differ where they put the `.section` directives relative to the `.text`, but once assembled there's no difference from an object file perspective.  I find putting the `__patchable_function_entries` outside of the function a nice touch. Thanks for the patch @MaskRay !



================
Comment at: llvm/test/CodeGen/AArch64/patchable-function-entry-bti.ll:15
+;; For M=0, place the label .Lpatch0 after the initial BTI.
 define void @f1() "patchable-function-entry"="1" "branch-target-enforcement" {
 ; CHECK-LABEL: f1:
----------------
Would it be helpful have a test for `patchable-function-entry > 1` and `branch-target-enforcement`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73680/new/

https://reviews.llvm.org/D73680