[PATCH] D73677: MSVC Buggy version detection: turn pre-processor error into CMake configuration time check

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 06:40:29 PST 2020


RKSimon added a comment.

I've confirmed with this patch I can build llvm again using vs2019 latest (16.4.3), with the following (expected) test fails:

  Failing Tests (4):
      LLVM :: MC/MachO/gen-dwarf-cpp.s
      LLVM :: MC/MachO/gen-dwarf-macro-cpp.s
      LLVM :: MC/MachO/gen-dwarf-producer.s
      LLVM :: MC/MachO/gen-dwarf.s

Oddly I didn't need the sal.h include but this should probably be left in for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73677/new/

https://reviews.llvm.org/D73677





More information about the llvm-commits mailing list