[PATCH] D73677: MSVC Buggy version detection: turn pre-processor error into CMake configuration time check

Thu Jan 30 05:54:32 PST 2020

hans added inline comments.

================
Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:56
+# on llvm-dev Jan 21-23 2020.
+if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC" AND CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 19.24)
+  if(LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN)
----------------
I think the full CMAKE_CXX_COMPILER_VERSION has more components, e.g. 19.16.27034.0. Maybe it should check >= 19.24 and < 19.25?

================
Comment at: llvm/include/llvm/Support/Compiler.h:26
-#if defined(_MSC_VER)
-#include <sal.h>
-
----------------
These two lines are unrelated and shouldn't be removed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73677/new/

https://reviews.llvm.org/D73677