[PATCH] D73478: [DebugInfo] replaceDbgUsesWithUndef before removing single store alloca

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

Also - it might be handy to describe when/where/how this particular change is important. While testing in isolation like this is probably the right thing - at least in this example, while it has an effect on the generated IR, it doesn't seem to have an effect on the resulting object file. (either way we still get no locations for these variables because they get entirely optimized away) - I'm guessing the case where it's observable in the resulting DWARF and debugger experience is if there's another codepath that does keep a location - without your changes, that other location would maybe wash out/extend over this range, where it should really be undef instead. (so including such an example in the comments/commit message - not as a test case, might be illustrative for review/historic purposes)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73478/new/

https://reviews.llvm.org/D73478