[PATCH] D73478: [DebugInfo] replaceDbgUsesWithUndef before removing single store alloca

Mon Jan 27 09:15:08 PST 2020

dblaikie added a comment.

In D73478#1842183 <https://reviews.llvm.org/D73478#1842183>, @probinson wrote:

> Please add the `debug-info` tag to these reviews.
>
> I know off-list I recommended doing all your transform-related patches separately, but... given that this and D73473 <https://reviews.llvm.org/D73473> are both in SROA, I think the tests at least should be combined into one test file (which reduces testing overhead).  And in general it should be fine to combine patches for the same pass into a single patch.

I'd probably still vote for separate patches for separate fixes - better for bisection, etc. (separate test cases in the same test file's OK though - different IR functions that exercise each different path) But wouldn't quibble over this specific instance (not worth the churn of back and forth between split/merged/etc) - just for future reference/my 2c.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73478/new/

https://reviews.llvm.org/D73478