[PATCH] D73370: [MVE] Fixup order of gather writeback intrinsic outputs.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham accepted this revision.
simon_tatham marked an inline comment as done.
simon_tatham added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp:2522
+  ReplaceUses(SDValue(N, 1), SDValue(New, 0));
+  ReplaceUses(SDValue(N, 2), SDValue(New, 2));
+  CurDAG->RemoveDeadNode(N);
----------------
dmgreen wrote:
> simon_tatham wrote:
> > This line looks redundant?
> The ReplaceUses? It's attempting to replace the chain operand of N with New. We have to create a new node now (I think), as opposed to morphing the existing value, so need to transfer over the chain too.
Oh yes. Blame Monday morning. I somehow misread it as the common idiom of updating a node in place.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73370/new/

https://reviews.llvm.org/D73370