[PATCH] D73370: [MVE] Fixup order of gather writeback intrinsic outputs.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 04:14:36 PST 2020


dmgreen marked an inline comment as done.
dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp:2522
+  ReplaceUses(SDValue(N, 1), SDValue(New, 0));
+  ReplaceUses(SDValue(N, 2), SDValue(New, 2));
+  CurDAG->RemoveDeadNode(N);
----------------
simon_tatham wrote:
> This line looks redundant?
The ReplaceUses? It's attempting to replace the chain operand of N with New. We have to create a new node now (I think), as opposed to morphing the existing value, so need to transfer over the chain too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73370/new/

https://reviews.llvm.org/D73370





More information about the llvm-commits mailing list