[PATCH] D73277: [LoopUnroll] Remove remapInstruction().

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 12:00:26 PST 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Transforms/Utils/LoopUnroll.cpp:570
   for (unsigned It = 1; It != ULO.Count; ++It) {
-    std::vector<BasicBlock*> NewBlocks;
+    SmallVector<BasicBlock *, 6> NewBlocks;
     SmallDenseMap<const Loop *, Loop *, 4> NewLoops;
----------------
Nit: Usually ppl choose powers of two for the size and there seems little reason not to make it 8.


================
Comment at: llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp:315
   for (unsigned It = 1; It != Count; ++It) {
-    std::vector<BasicBlock *> NewBlocks;
+    SmallVector<BasicBlock *, 6> NewBlocks;
     // Maps Blocks[It] -> Blocks[It-1]
----------------
Same as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73277/new/

https://reviews.llvm.org/D73277





More information about the llvm-commits mailing list