[PATCH] D73277: [LoopUnroll] Remove remapInstruction().

[Whitney Tsang via Phabricator via llvm-commits]

Whitney created this revision.
Whitney added reviewers: dmgreen, jdoerfert, Meinersbur, kbarton, bmahjour, etiotto, foad, aprantl.
Whitney added a project: LLVM.
Herald added subscribers: llvm-commits, zzheng, hiraditya.

LoopUnroll can reuse the RemapInstruction() in ValueMapper, or remapInstructionsInBlocks() in CloneFunction, depending on the needs.
There is no need to have its own version in LoopUnroll.

By calling RemapInstruction() without TypeMapper or Materializer and with Flags (RF_NoModuleLevelChanges  | RF_IgnoreMissingLocals), it does the same as remapInstruction(). remapInstructionsInBlocks() calls RemapInstruction() exactly as described.

Looking at the history, I cannot find any obvious reason to have its own version.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73277

Files:
  llvm/include/llvm/Transforms/Utils/UnrollLoop.h
  llvm/lib/Transforms/Utils/LoopUnroll.cpp
  llvm/lib/Transforms/Utils/LoopUnrollAndJam.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73277.239911.patch
Type: text/x-patch
Size: 3827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200123/11cef588/attachment-0001.bin>