[PATCH] D73044: {tablegen] Emit string literals instead of char arrays

Luke Drummond via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 03:41:07 PST 2020


ldrumm updated this revision to Diff 239272.
ldrumm added a comment.

Change the cmake flag check to `if(MSVC)` rather than `if(CMAKE_GENERATOR MATCHES "Visual Studio")`. `CMAKE_GENERATOR` is not the compiler


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73044/new/

https://reviews.llvm.org/D73044

Files:
  cmake/modules/TableGen.cmake
  utils/TableGen/AsmWriterEmitter.cpp
  utils/TableGen/CMakeLists.txt
  utils/TableGen/InstrInfoEmitter.cpp
  utils/TableGen/RegisterInfoEmitter.cpp
  utils/TableGen/SequenceToOffsetTable.h
  utils/TableGen/TableGen.cpp
  utils/TableGen/tablegen-config.h.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73044.239272.patch
Type: text/x-patch
Size: 9968 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200121/2d749921/attachment.bin>


More information about the llvm-commits mailing list