[PATCH] D73044: {tablegen] Emit string literals instead of char arrays

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 20 13:22:55 PST 2020


mstorsjo added inline comments.


================
Comment at: cmake/modules/TableGen.cmake:68
+    # in length. Ensure tablgen works around this when the generator is VS
+    set(tblgen_long_string_literals_flag "--long-string-literals=0")
   else()
----------------
I think this needs to go inside a `if (MSVC)` clause instead, as the generator often can be Ninja even though you're building with MSVC.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73044/new/

https://reviews.llvm.org/D73044





More information about the llvm-commits mailing list