[PATCH] D72805: [X86] Remove X86ISD::FILD_FLAG and stop gluing nodes together.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 18 21:30:25 PST 2020


craig.topper added a comment.

In D72805#1828063 <https://reviews.llvm.org/D72805#1828063>, @RKSimon wrote:

> Cheers Craig, TBH I'm left wondering whether we should tweak the update script to always keep stack arithmetic for x86 - do you think they'd be too much churn?


Would probably cause a lot of churn in the near term, but we regularly regenerate tests before patches so maybe not a big deal? Another option might be to just add an option to disable like the x86_scrub_rip/no_x86_scrub_rip option?

> Anyway, LGTM as a first step, but it highlights a number of topics for further possible work (nothing new there......).




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72805/new/

https://reviews.llvm.org/D72805





More information about the llvm-commits mailing list