[PATCH] D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 00:44:40 PST 2020


djtodoro added a comment.

Nice, thanks! Please post the rest of the patches, when you are ready, and make a stack of the patches.

> This five patches reduces 'total availability' metric of clang binary
> (debug build) from 126% to 87%.

I guess we are talking about the build with `-g -O2`?



================
Comment at: llvm/tools/llvm-dwarfdump/Statistics.cpp:160
 }
+/// Construct a (probably) unique identificator for a given DIE,
+/// including Prefix, Name, FileName and Line.
----------------
Could you please add an explanation here why '(probably)'?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72797/new/

https://reviews.llvm.org/D72797





More information about the llvm-commits mailing list