[PATCH] D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 15 12:14:25 PST 2020


aprantl added a comment.

> This five patches reduces 'total availability' metric of clang binary (debug build) from 126% to 87%.

For a debug build you'd expect 100% where are the missing 13% coming from?

Otherwise this change seems to go into the right direction.



================
Comment at: llvm/tools/llvm-dwarfdump/Statistics.cpp:393
         return;
+      // Skip weird functions w/o names.
+      if (StringRef(Die.getName(DINameKind::LinkageName)).empty())
----------------
When are these generated? Could we write something more descriptive into the comment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72797/new/

https://reviews.llvm.org/D72797





More information about the llvm-commits mailing list