[PATCH] D72475: [WIP] Build assume from call

Tyker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 14 16:43:34 PST 2020


Tyker added inline comments.
Herald added a subscriber: mgrang.


================
Comment at: llvm/include/llvm/Transforms/Utils/AssumeBuilder.h:25
+  return BuildAssumeFromInst(I, I->getModule());
+}
+
----------------
jdoerfert wrote:
> Arguably, you only need to expose one version, e.g., the single instruction one (with const). In the impl. we can query the module.
the module can't be const because of Intrinsic::getDeclaration requires a non-const Module. so it can't be optained from a const Instruction.
the other solution is const_cast, but i don't like it so much.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72475/new/

https://reviews.llvm.org/D72475





More information about the llvm-commits mailing list