[PATCH] D72475: [WIP] Build assume from call

[Tyker via Phabricator via llvm-commits]

Tyker updated this revision to Diff 238139.
Tyker marked 6 inline comments as done.
Tyker added a comment.
Herald added a subscriber: mgrang.

i renamed the files to KnowledgeRetention.* to be more general. we can put other related utilities like the query API in the same files. i had a hard time finding a good name and i am not sure i succeeded what do you think ?

i also fixed an issue were the order of bundles was non-deterministic. to do so i had to add a sort, but this sort can be used later to find bundles by binary search in the API.

In D72475#1818682 <https://reviews.llvm.org/D72475#1818682>, @jdoerfert wrote:

> We should not land it right away though


is it because the creation of the clang-10 release branch is happening soon or because we need to benchmarks first ?

> If you write the API next, either of us can make use of it in the Attributor.

we can make the API and the first user of the API come at the same time so we can test the API transitively ? or this would make the patch too big ? I haven't taken a detailed enough look at the Attributor but i need to get to know it anyway.

> Lastly we need to generate the calls in the first place and we can try this out on benchmarks.

agreed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72475/new/

https://reviews.llvm.org/D72475

Files:
  llvm/include/llvm/IR/Attributes.h
  llvm/include/llvm/Transforms/Utils/KnowledgeRetention.h
  llvm/lib/IR/Attributes.cpp
  llvm/lib/IR/Core.cpp
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/lib/Transforms/Utils/CMakeLists.txt
  llvm/lib/Transforms/Utils/KnowledgeRetention.cpp
  llvm/test/Transforms/Util/assume-builder.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72475.238139.patch
Type: text/x-patch
Size: 16534 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200115/499d93b5/attachment.bin>