[PATCH] D69836: [MIR] Target specific MIR formating and parsing

Peng Guo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 10 10:31:53 PST 2020


pguo marked 2 inline comments as done.
pguo added inline comments.


================
Comment at: llvm/lib/Target/TargetMachine.cpp:15
 #include "llvm/Analysis/TargetTransformInfo.h"
+#include "llvm/CodeGen/MIRFormatter.h"
 #include "llvm/IR/Function.h"
----------------
kadircet wrote:
> this seems to be causing a layering violation, as codegen already depends on Target. Is it possible to restructure this change in a way to prevent this cycle?
> This doesn't brake cmake builds but is causing problems in strict build systems. 
This is fixed by https://reviews.llvm.org/D72485.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69836/new/

https://reviews.llvm.org/D69836





More information about the llvm-commits mailing list