[PATCH] D69836: [MIR] Target specific MIR formating and parsing

[Daniel Sanders via Phabricator via llvm-commits]

dsanders added a subscriber: bkramer.
dsanders added inline comments.


================
Comment at: llvm/lib/Target/TargetMachine.cpp:15
 #include "llvm/Analysis/TargetTransformInfo.h"
+#include "llvm/CodeGen/MIRFormatter.h"
 #include "llvm/IR/Function.h"
----------------
pguo wrote:
> kadircet wrote:
> > this seems to be causing a layering violation, as codegen already depends on Target. Is it possible to restructure this change in a way to prevent this cycle?
> > This doesn't brake cmake builds but is causing problems in strict build systems. 
> This is fixed by https://reviews.llvm.org/D72485.
Peng was working on fixing that yesterday. It looks like it landed in https://reviews.llvm.org/rGcfd849840134 (Thanks @bkramer for committing it). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69836/new/

https://reviews.llvm.org/D69836