[PATCH] D68203: Add support for (expressing) vscale.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/include/llvm/IR/PatternMatch.h:2021
+  int &Val;
+  VScaleVal_match(const DataLayout &DL, int &S) : DL(DL), Val(S) {}
+
----------------
Nit: how about renaming `S` to `Scaling` or something along those lines?


================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:1108
+  // General case that we ideally never want to match.
+  def : Pat<(vscale GPR64:$scale), (MADDXrrr (UBFMXri (RDVLI_XI 1), 4, 63), $scale, XZR)>;
+
----------------
last question: is there a test case for this, can this be triggered?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68203/new/

https://reviews.llvm.org/D68203