[PATCH] D71919: [LoopVectorize] Disable single stride access predicates when gather loads are available.

[Dave Green via Phabricator via llvm-commits]

dmgreen marked an inline comment as done.
dmgreen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4599
+                 ? isLegalMaskedLoad(Ty, Ptr, Alignment)
+                 : isLegalMaskedStore(Ty, Ptr, Alignment));
   }
----------------
Ayal wrote:
> Thanks!
> nit: may look better to have instead
> 
> ```
>   bool isLegalMaskedLoadOrStore = isa<LoadInst>(I) ? isLegalMaskedLoad(Ty, Ptr, Alignment)
>                                                    : isLegalMaskedStore(Ty, Ptr, Alignment);
>   return !(isLegalMaskedLoadOrStore || TTI.isLegalGatherOrScatter(I));
> ```
> (in anticipation of TTI.isLegalMaskedLoadOrStore())
I've put up the isLegalMaskedLoadStore patch in D72387.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71919/new/

https://reviews.llvm.org/D71919