[PATCH] D71919: [LoopVectorize] Disable single stride access predicates when gather loads are available.

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 7 14:35:35 PST 2020


Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:4599
+                 ? isLegalMaskedLoad(Ty, Ptr, Alignment)
+                 : isLegalMaskedStore(Ty, Ptr, Alignment));
   }
----------------
Thanks!
nit: may look better to have instead

```
  bool isLegalMaskedLoadOrStore = isa<LoadInst>(I) ? isLegalMaskedLoad(Ty, Ptr, Alignment)
                                                   : isLegalMaskedStore(Ty, Ptr, Alignment);
  return !(isLegalMaskedLoadOrStore || TTI.isLegalGatherOrScatter(I));
```
(in anticipation of TTI.isLegalMaskedLoadOrStore())


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71919/new/

https://reviews.llvm.org/D71919





More information about the llvm-commits mailing list