[PATCH] D72223: [LLVM] [MLIR] Introduce affine graybox op

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 5 07:07:45 PST 2020


bondhugula marked an inline comment as done.
bondhugula added inline comments.


================
Comment at: mlir/docs/Dialects/Affine.md:612
+be a *memref*.  The operands bind 1:1 to its region's arguments.  The op can't
+use any memrefs defined outside of it, but can use any other SSA values that
+dominate it. Its region's blocks can have terminators the same way as current
----------------
mehdi_amini wrote:
> I don’t think you addressed my concerns on this topic?
I think I responded to everything and included all of the arguments in the RFC:
https://github.com/bondhugula/llvm-project/blob/graybox/mlir/rfc/rfc-graybox.md
Could you just provide a summary list of the concerns you still have - either here or on that thread as you prefer?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72223/new/

https://reviews.llvm.org/D72223





More information about the llvm-commits mailing list