[PATCH] D72223: [LLVM] [MLIR] Introduce affine graybox op

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 5 05:53:38 PST 2020


mehdi_amini requested changes to this revision.
mehdi_amini added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/docs/Dialects/Affine.md:612
+be a *memref*.  The operands bind 1:1 to its region's arguments.  The op can't
+use any memrefs defined outside of it, but can use any other SSA values that
+dominate it. Its region's blocks can have terminators the same way as current
----------------
I don’t think you addressed my concerns on this topic?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72223/new/

https://reviews.llvm.org/D72223





More information about the llvm-commits mailing list