[llvm] aa82172 - [XRay][test] Fix xray-empty-firstmbb.mir and delete incorrect xray-empty-function.mir

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 1 22:21:27 PST 2020


Author: Fangrui Song
Date: 2020-01-01T22:21:11-08:00
New Revision: aa8217289864d27b023b31e3efbaa7eb05e77092

URL: https://github.com/llvm/llvm-project/commit/aa8217289864d27b023b31e3efbaa7eb05e77092
DIFF: https://github.com/llvm/llvm-project/commit/aa8217289864d27b023b31e3efbaa7eb05e77092.diff

LOG: [XRay][test] Fix xray-empty-firstmbb.mir and delete incorrect xray-empty-function.mir

xray-empty-firstmbb.mir does not test the intended code path. Change
xray-instruction-threshold to 0 to exercise the code path.

Delete xray-empty-function.mir . Empty MachineFunction does not work.
Various passes (e.g. MachineDominatorTree) assume the presence of an
entry block.

Added: 
    

Modified: 
    llvm/test/CodeGen/X86/xray-empty-firstmbb.mir

Removed: 
    llvm/test/CodeGen/X86/xray-empty-function.mir


################################################################################
diff  --git a/llvm/test/CodeGen/X86/xray-empty-firstmbb.mir b/llvm/test/CodeGen/X86/xray-empty-firstmbb.mir
index 5949a4add157..e87c86591ce8 100644
--- a/llvm/test/CodeGen/X86/xray-empty-firstmbb.mir
+++ b/llvm/test/CodeGen/X86/xray-empty-firstmbb.mir
@@ -4,7 +4,7 @@
 
 --- |
 
-  define i32 @foo() noinline uwtable "xray-instruction-threshold"="1" {
+  define i32 @foo() noinline uwtable "xray-instruction-threshold"="0" {
   entry:
     unreachable
   }

diff  --git a/llvm/test/CodeGen/X86/xray-empty-function.mir b/llvm/test/CodeGen/X86/xray-empty-function.mir
deleted file mode 100644
index 178771a3c63a..000000000000
--- a/llvm/test/CodeGen/X86/xray-empty-function.mir
+++ /dev/null
@@ -1,13 +0,0 @@
-# RUN: llc -run-pass xray-instrumentation -mtriple=x86_64-unknown-linux-gnu -o - %s | FileCheck %s
-#
-# Make sure we can handle empty functions.
----
-name: empty
-tracksRegLiveness: true
-liveins:
-  - { reg: '$edi'}
-body:            |
-  bb.0:
-    ; CHECK-NOT: PATCHABLE_FUNCTION_ENTER
-...
-


        


More information about the llvm-commits mailing list