[PATCH] D71631: [ELF] writePLT: replace parameters gotPltEntryAddr and index with `const Symbol &`. NFC

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 23:49:22 PST 2019


ruiu accepted this revision.
ruiu added a comment.

I think I like `sym` over `s` as a function parameter name whose scope is not very narrow, but except that LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71631/new/

https://reviews.llvm.org/D71631





More information about the llvm-commits mailing list