[PATCH] D71631: [ELF] writePLT: replace parameters gotPltEntryAddr and index with `const Symbol &`. NFC

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 17 23:40:10 PST 2019


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/Arch/Mips.cpp:323
+                          uint64_t pltEntryAddr) const {
+  uint64_t gotPltEntryAddr = s.getGotPltVA();
   if (isMicroMips()) {
----------------
It is used only once in each branch, so perhaps just inline it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71631/new/

https://reviews.llvm.org/D71631





More information about the llvm-commits mailing list