[PATCH] D71418: [llvm-readobj] - Fix letters used for dumping section types in GNU style.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 12 06:26:24 PST 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay, rupprecht.
Herald added subscribers: seiya, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

I've noticed that when we have all regular flags set, we print "WAEXMSILoGTx"
instead of "WAXMSILOGTCE" printed by GNU readelf.

It happens because:

1. We print SHF_EXCLUDE at the wrong place.
2. We do not recognize SHF_COMPRESSED, we print "x" instead of "C".
3. We print "o" instead of "O" for SHF_OS_NONCONFORMING.

This patch fixes differences and adds test cases.


https://reviews.llvm.org/D71418

Files:
  llvm/test/tools/llvm-readobj/ELF/section-flags.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71418.233603.patch
Type: text/x-patch
Size: 5890 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191212/68eaa1d3/attachment.bin>


More information about the llvm-commits mailing list