[llvm] 84a9756 - [llvm-dwarfdump] Add blank line after printing line table

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 12 06:09:07 PST 2019


Author: James Henderson
Date: 2019-12-12T14:06:10Z
New Revision: 84a9756a72d81c32972b85c1d11cfd391f5b93a6

URL: https://github.com/llvm/llvm-project/commit/84a9756a72d81c32972b85c1d11cfd391f5b93a6
DIFF: https://github.com/llvm/llvm-project/commit/84a9756a72d81c32972b85c1d11cfd391f5b93a6.diff

LOG: [llvm-dwarfdump] Add blank line after printing line table

This helps delineate it in the output from later tables or other output.

Reviewed by: JDevlieghere

Differential Revision: https://reviews.llvm.org/D71344

Added: 
    

Modified: 
    llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
    llvm/test/tools/llvm-dwarfdump/X86/debug-line.s

Removed: 
    


################################################################################
diff  --git a/llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp b/llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
index a1835be344e5..445f4bf48a71 100644
--- a/llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
+++ b/llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
@@ -461,6 +461,10 @@ void DWARFDebugLine::LineTable::dump(raw_ostream &OS,
       R.dump(OS);
     }
   }
+
+  // Terminate the table with a final blank line to clearly delineate it from
+  // later dumps.
+  OS << '\n';
 }
 
 void DWARFDebugLine::LineTable::clear() {

diff  --git a/llvm/test/tools/llvm-dwarfdump/X86/debug-line.s b/llvm/test/tools/llvm-dwarfdump/X86/debug-line.s
index bd625427e9c1..7184bc531c09 100644
--- a/llvm/test/tools/llvm-dwarfdump/X86/debug-line.s
+++ b/llvm/test/tools/llvm-dwarfdump/X86/debug-line.s
@@ -43,6 +43,7 @@
 # CHECK-NEXT: 0x0000000000000002      1      0      1   0             0  is_stmt
 # CHECK-NEXT: 0x0000000000000002      1      4      3   0             0  is_stmt
 # CHECK-NEXT: 0x0000000000000024      1      4      3   5             6  basic_block prologue_end epilogue_begin end_sequence
+# CHECK-EMPTY:
 # CHECK-NEXT: debug_line[0x0000006d]
 # CHECK-NEXT: Line table prologue:
 # CHECK-NEXT:     total_length: 0x0000001b


        


More information about the llvm-commits mailing list