[llvm] 942c994 - [Loop] Add isRotated method to Loop class.

[Philip Reames via llvm-commits]

Just land it.

Philip

On 12/11/19 1:07 PM, Kit Barton wrote:
> Thanks Michael and Philip for the clarification. I was going to ask 
> the same question.
>
> Do either of you object if I commit a fix to change the name, with an 
> appropriate comment block? Or would you prefer I post something on 
> Phabricator for review?
> Kit Barton, Ph.D.
> STSM, Technical lead for LLVM on Power and XL Compilers
> IBM Toronto Lab, C2/705/8200/MKM
> 8200 Warden Ave, Markham, L6G 1C7
> (905) 413-3452
> kbarton at ca.ibm.com
>
>     ----- Original message -----
>     From: Philip Reames <listmail at philipreames.com>
>     To: Michael Kruse <llvm-commits at meinersbur.de>
>     Cc: Kit Barton <kbarton at ca.ibm.com>, Kit Barton
>     <llvmlistbot at llvm.org>, llvm-commits <llvm-commits at lists.llvm.org>
>     Subject: [EXTERNAL] Re: [llvm] 942c994 - [Loop] Add isRotated
>     method to Loop class.
>     Date: Wed, Dec 11, 2019 3:53 PM
>     On 12/11/19 12:45 PM, Michael Kruse wrote:
>     > Am Mi., 11. Dez. 2019 um 11:11 Uhr schrieb Philip Reames via
>     > llvm-commits <llvm-commits at lists.llvm.org>:
>     >> Can you add a more detailed method comment as to what rotated
>     means in
>     >> this context?  In particular, it doesn't imply the loop has been
>     >> rotated, it checks the form of the loop structure.
>     > By "has been rotated", do you mean that LoopRotate transformed the
>     > loop, excluding that cases where LoopRotate did not do anything
>     or did
>     > not run?
>     > Would calling the method "isRotatedForm()" disambiguate this?
>     Yes, and yes.
>     >
>     > Michael
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191211/9f363a4b/attachment.html>